doctor: hoist duplicated doc-path and message literals into constants #67

Closed
opened 2026-10-19 15:26:42 +02:00 by pti · 0 comments
Owner

Sonar go:S1192 flags nine files in internal/doctor for repeated literals, mainly DocRef paths such as docs/configuration.qmd, docs/isolated-environments.md, design/doctor/wraptool-doctor.md and design/policy/security-audit-policy-enforcement.md, plus repeated finding texts in exposure_files.go, config_perms.go, runtime.go and pool.go. Hoist the doc paths into a single docref.go constant block and the repeated messages into named constants next to their checks. Mechanical, one PR, golden-output tests must stay byte-identical. Part of the SonarQube cleanup tracking issue.

Sonar go:S1192 flags nine files in internal/doctor for repeated literals, mainly DocRef paths such as docs/configuration.qmd, docs/isolated-environments.md, design/doctor/wraptool-doctor.md and design/policy/security-audit-policy-enforcement.md, plus repeated finding texts in exposure_files.go, config_perms.go, runtime.go and pool.go. Hoist the doc paths into a single docref.go constant block and the repeated messages into named constants next to their checks. Mechanical, one PR, golden-output tests must stay byte-identical. Part of the SonarQube cleanup tracking issue.
pti closed this issue 2026-10-19 15:56:59 +02:00
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
pti/wraptool#67
No description provided.