pool: modernize seed_cache_index.js, node: import prefixes, top-level await, PATH check #69
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Sonar flags six findings in internal/pool/source/seed_cache_index.js. Four javascript:S7772 ask for the node: scheme on the url, fs, path and child_process requires. One javascript:S7785 asks for top-level await instead of a promise chain. One javascript:S4036, the only item Sonar classifies as a vulnerability, asks to make sure PATH only contains fixed unwriteable directories when spawning a child. Check whether the script sets an explicit PATH or spawns by absolute path, and fix or document. Small PR, the npm integration test covers the script. Part of the SonarQube cleanup tracking issue.