reduce cognitive complexity in production functions flagged by go:S3776

pti commented

2026-10-19 15:26:43 +02:00

Owner

Sonar go:S3776 flags 50 production functions above complexity 15. Worst first: internal/mcptools/cli_source.go at 55, internal/doctor/doctor.go at 39, internal/config/edit.go at 39, internal/pool/gc.go at 37, internal/pool/orchestrator.go with five functions between 28 and 36, internal/mcptools/request_tool.go at 36, internal/introspect/parser_git.go at 36 and 27, cmd/harness.go at 34, cmd/up.go at 32, internal/doctor/suppress.go at 30, internal/pool/source/npm.go at 27. After the threshold moves to 25 per the sonar config issue, about 37 remain. Work one package per PR, extract helpers, no behaviour change, whole-branch review per .claude/agents/README.md since these touch policy and pool code. Order: mcptools first, then config and doctor, then pool, then cmd. Part of the SonarQube cleanup tracking issue.

pti referenced this issue

2026-10-19 22:23:26 +02:00

refactor/doctor: split Run and suppressWalk into helpers #90

pti referenced this issue

2026-10-19 22:23:28 +02:00

refactor/introspect: split the git-style subcommand and flag parsers into helpers #91

pti referenced this issue from a commit

2026-10-19 22:27:00 +02:00

refactor(pool): split retainedCacheDigests, Decide and NPM.Fetch into helpers

pti referenced this issue

2026-10-19 22:27:19 +02:00

refactor/pool: split retainedCacheDigests, Decide and NPM.Fetch into helpers #92