pti/wraptool
Watch
1
0
Fork
You've already forked wraptool
 0
Code Issues 2 Pull requests Projects Releases 13 Packages 5 Wiki Activity Actions

refactor/pool: name the repeated sha256 prefix literal #97

Merged
pti merged 1 commit from refactor/literals-pool into main 2026-10-19 22:46:33 +02:00
Conversation 0 Commits 1 Files changed 1 +3 -3
pti commented 2026-10-19 22:42:55 +02:00
Owner

Part of the SonarQube cleanup in #73, the pool slice of the go:S1192 duplicated-literal findings. The three recipe-revision functions in orchestrator.go each spelled the sha256: digest prefix as a literal. They now use the sha256DigestPrefix constant that receipt.go already defined for the same format. Output bytes are unchanged, the golden recipe-revision tests pass untouched. 🤖 Generated with Claude Code

Part of the SonarQube cleanup in #73, the pool slice of the go:S1192 duplicated-literal findings. The three recipe-revision functions in orchestrator.go each spelled the sha256: digest prefix as a literal. They now use the sha256DigestPrefix constant that receipt.go already defined for the same format. Output bytes are unchanged, the golden recipe-revision tests pass untouched. 🤖 Generated with Claude Code
refactor(pool): name the repeated sha256 prefix literal
All checks were successful
Lint / lint (pull_request) Successful in 50s
Details
Lint / sonarqube (pull_request) Has been skipped
Details
5b9b5a6e38 
The three digest-building returns in orchestrator.go spelled out the
"sha256:" literal even though receipt.go already defines
sha256DigestPrefix for exactly this format. Use the existing constant so
the prefix has one source; output bytes are unchanged.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
pti merged commit 44e4b660a8 into main 2026-10-19 22:46:33 +02:00
pti deleted branch refactor/literals-pool 2026-10-19 22:46:33 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
pti/wraptool!97
No description provided.