pti/wraptool
Watch
1
0
Fork
You've already forked wraptool
 0
Code Issues 2 Pull requests Projects Releases 13 Packages 5 Wiki Activity Actions

refactor/pool-source: name the repeated node_modules and package.json literals #99

Merged
pti merged 1 commit from refactor/literals-pool-source into main 2026-10-19 22:46:57 +02:00
Conversation 0 Commits 1 Files changed 2 +16 -9
pti commented 2026-10-19 22:44:08 +02:00
Owner

Part of the SonarQube cleanup in #73, the pool source slice. Two go:S1192 findings. The package-lock key prefix node_modules/ in npm.go and realize.go becomes nodeModulesPrefix, and the package.json manifest filename across both files becomes packageJSONFile. Every path and lock key is byte-identical, the lib/node_modules format strings in realize.go are left alone as a different shape. The npm realize integration tests ran and pass. 🤖 Generated with Claude Code

Part of the SonarQube cleanup in #73, the pool source slice. Two go:S1192 findings. The package-lock key prefix node_modules/ in npm.go and realize.go becomes nodeModulesPrefix, and the package.json manifest filename across both files becomes packageJSONFile. Every path and lock key is byte-identical, the lib/node_modules format strings in realize.go are left alone as a different shape. The npm realize integration tests ran and pass. 🤖 Generated with Claude Code
refactor/pool-source: name the repeated node_modules and package.json literals
All checks were successful
Lint / lint (pull_request) Successful in 1m11s
Details
Lint / sonarqube (pull_request) Has been skipped
Details
9a0477ee5c 
The package-lock key prefix node_modules/ and the manifest file name
package.json each appeared several times across npm.go and realize.go.
Name them once (nodeModulesPrefix, packageJSONFile) so Sonar's go:S1192
stops flagging them. Behaviour-neutral: every resulting path and key is
byte-identical.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
pti merged commit c9ff83baf4 into main 2026-10-19 22:46:57 +02:00
pti deleted branch refactor/literals-pool-source 2026-10-19 22:46:57 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
pti/wraptool!99
No description provided.